Fix FiberDoubleForString#length to work with strings in any encoding

CHANGELOG.md

@@ -5,6 +5,10 @@
 * [HexaPDF::Document::Metadata] for working with metadata (reading the info
  dictionary and writing it as well as the XMP metadata stream)
 
+### Fixed
+
+* [HexaPDF::FiberDoubleForString#length] to not assume a binary string
+
 
 ## 0.36.0 - 2024-01-20
 

lib/hexapdf/filter.rb

@@ -69,11 +69,11 @@ def initialize(str = nil, &block)
  @block_used = false
  end
 
- # Returns the length of the wrapped string.
+ # Returns the length in bytes of the wrapped string.
  #
  # May only be called before #resume!
  def length
- str.length
+ str.bytesize
  end
 
  # Returns +true+ if #resume has not yet been called.

test/hexapdf/test_filter.rb

@@ -18,6 +18,12 @@
  assert_equal(@str, collector(fib))
  assert_equal('', collector(fib))
  end
+
+ it "returns the correct length of the fiber" do
+ str = "\u{FEFF}Öl"
+ fib = @obj.source_from_proc { str }
+ assert_equal(6, fib.length)
+ end
  end
 
  describe "source_from_string" do
@@ -30,6 +36,12 @@
  it "returns the whole string" do
  assert_equal(@str, collector(@obj.source_from_string(@str)))
  end
+
+ it "returns the correct size of the fiber" do
+ str = "\u{FEFF}Öl"
+ fib = @obj.source_from_string(str)
+ assert_equal(6, fib.length)
+ end
  end
 
  describe "source_from_io" do