Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix for darkgraylib requiring version for argparser #588

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

Svenito
Copy link
Collaborator

@Svenito Svenito commented May 20, 2024

the argparser in the darkgraylib was using the library version instead of the version of the module calling it

See akaihola/darkgraylib#64

@Svenito Svenito requested a review from akaihola May 20, 2024 16:30
@Svenito Svenito changed the title A fix to darkgraylib requires version for argparser A fix for darkgraylib requiring version for argparser May 20, 2024
@Svenito Svenito self-assigned this May 20, 2024
Copy link
Owner

@akaihola akaihola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Svenito!

@akaihola akaihola force-pushed the show-darker-version branch 2 times, most recently from f67f965 to bc3b785 Compare July 29, 2024 15:57
Svenito and others added 2 commits July 29, 2024 19:14
the argparser in the darkgraylib was using the library version instead
of the version of the module calling it
@akaihola akaihola merged commit f5f3fe7 into akaihola:master Jul 29, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants