Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup #18

Merged
merged 1 commit into from
Jul 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/lib/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ export class Fzf<U> {
let sidx = -1,
eidx = -1;
if (match.allPos.length > 0) {
// FIXME offset calulation for min and max needs to be fixed when we'll introduce Tiebreaker
// as sidx and eidx needs to be calculated from whole offsets list element not alone from the first element.
// https://github.com/junegunn/fzf/blob/764316a53d0eb60b315f0bbcd513de58ed57a876/src/result.go#L25
sidx = Math.min(...match.allPos);
eidx = Math.max(...match.allPos) + 1;
}
Expand Down
3 changes: 0 additions & 3 deletions src/lib/pattern.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ export function buildPatternForExtendedSearch(
}

return {
// case sensitive will always remain true for extended match
// caseSensitive: true,

// this modified str can be used as cache as pattern cache
// see https://github.com/junegunn/fzf/blob/7191ebb615f5d6ebbf51d598d8ec853a65e2274d/src/pattern.go#L100
//
Expand Down