Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor skill implementations to use some kind of registry #105

Open
ajhyndman opened this issue Sep 28, 2017 · 0 comments
Open

Refactor skill implementations to use some kind of registry #105

ajhyndman opened this issue Sep 28, 2017 · 0 comments
Labels
enhancement fire-emblem-heroes-calculator
Projects
fire-emblem-heroes-calculator
Milestone
fire-emblem-heroe...

Comments

@ajhyndman
Copy link
Owner

ajhyndman commented Sep 28, 2017 •
edited
Loading

I think it might be possible to ease maintenance by reorganising our skill implementations. I think this could allow you to add and remove which skills are available via a configurations step. It could also make this piece of our code more friendly to open source contributions.

Maybe using some kind of "plugin" or "hook" structure?
ajhyndman added a commit that referenced this issue Mar 23, 2018
@ajhyndman
Remove test assertions for broken skill
f623e25 
If I maintain this, I think the whole skill system needs an overhaul.

See: #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fire-emblem-heroes-calculator
Projects
fire-emblem-heroes-calculator
Awaiting triage
Milestone
fire-emblem-heroes-calculator 1.0.0
Development

No branches or pull requests
1 participant
@ajhyndman