Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR JS backend #291

Merged
merged 4 commits into from
May 14, 2021
Merged

IR JS backend #291

merged 4 commits into from
May 14, 2021

Conversation

jmfayard
Copy link
Contributor

No description provided.

@jmfayard jmfayard changed the title kotlin.js.compiler=both Enable consumers to use IR JS backend https://kotlinlang.org/docs/js-ir-compiler.html May 12, 2021
@jmfayard jmfayard changed the title Enable consumers to use IR JS backend https://kotlinlang.org/docs/js-ir-compiler.html Enable consumers to use IR JS backend May 12, 2021
@ajalt
Copy link
Owner

ajalt commented May 13, 2021

Thanks for the contribution.

  1. I'd prefer to enable the IR through the gradle DSL rather than a compiler flag
  2. We'd need to update kotest
  3. Ultimately, we're blocked from enabling this by KT-43490. I don't know of a workaround that wouldn't break backwards compatibility.

@jmfayard jmfayard mentioned this pull request May 13, 2021
Closed
@jmfayard
Copy link
Contributor Author

Thanks for the information, I opened an issue for kotest here kotest/kotest#2251

@jmfayard jmfayard changed the title Enable consumers to use IR JS backend R JS backend May 14, 2021
@jmfayard jmfayard changed the title R JS backend IR JS backend May 14, 2021
@jmfayard
Copy link
Contributor Author

kotest is now compatible with the IR backend!
I upgraded the dependency
and added a comment to document that this issue is correctly blocked by a bug in the IR backend

LouisCAD
LouisCAD reviewed May 14, 2021
View reviewed changes
clikt/build.gradle.kts Outdated Show resolved Hide resolved
@ajalt ajalt merged commit e086c37 into ajalt:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisCAD LouisCAD LouisCAD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmfayard @ajalt @LouisCAD