Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional rewrite rules before computing similarity scores during replay #499
Allow optional rewrite rules before computing similarity scores during replay #499
Changes from all commits
20532d0
4926e3b
9c493d1
4d5ae46
f1978d4
a99142b
e5fefc3
aad3942
a342c73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could we add a comment explaining the regex to the expressions in these tests? Will help identify the intention and to verify the output is expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"I hate dogs", blasphemy! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question Why is this first converted to any to then immediately be casted to T?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of
s
was resolved as a string with our manual checktypeof value === "string"
and subsequent castlet s = value as string
. However the top level recursed function has a generic type T which it needs to return.string
andT
don't overlap and the cast toany
is required to allow us to cast it to T afterwardsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a limitation of TypeScript. Line 54 casts the generic type
T
tostring
. We need to caststring
back toT
in order to return it. The compiler does not allow castingstring
directly toT
as there's no overlap of the types. Going viaany
is the way you do a "cast to anything" cast in TypeScript.