Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markerNames property #918

Merged
merged 6 commits into from
Jun 7, 2019
Merged

Add markerNames property #918

merged 6 commits into from
Jun 7, 2019

Conversation

dpt
Copy link
Contributor

@dpt dpt commented May 21, 2019 •
edited
Loading

This adds a new property markerNames to Animation which returns an array of all marker names.

There's a couple of C&P fixes in there too.

@dpt
Copy link
Contributor Author

dpt commented May 21, 2019

#849 is related.

@dpt dpt changed the title allMarkerNames Add markerNames property May 21, 2019
thedrick
thedrick reviewed May 28, 2019
View reviewed changes
Copy link
Contributor

@thedrick thedrick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding suggestions to match the style of the rest of the project. It would be great to batch these suggestions together (you can do this on the files tab) and commit them as one update to this PR.

lottie-swift/src/Private/Model/Animation.swift Outdated Show resolved Hide resolved
lottie-swift/src/Private/Model/Animation.swift Outdated Show resolved Hide resolved
lottie-swift/src/Private/Model/Animation.swift Outdated Show resolved Hide resolved
@dpt
Copy link
Contributor Author

dpt commented Jun 4, 2019

Are any other changes needed?

@buba447 buba447 merged commit dc2213b into airbnb:master Jun 7, 2019
@dpt dpt deleted the dpt/marker-names branch June 10, 2019 10:02
@dpt dpt restored the dpt/marker-names branch June 10, 2019 13:15
calda pushed a commit that referenced this pull request Nov 28, 2022
@buba447
Merge pull request #918 from dpt/dpt/marker-names
386b8e3 
Add markerNames property
calda pushed a commit that referenced this pull request Dec 1, 2022
@buba447
Merge pull request #918 from dpt/dpt/marker-names
1867a17 
Add markerNames property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedrick thedrick thedrick left review comments

@buba447 buba447 buba447 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpt @thedrick @buba447