Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.0.6 #906

Merged
merged 1 commit into from
May 14, 2019
Merged

Bump to 3.0.6 #906

merged 1 commit into from
May 14, 2019

Conversation

thedrick
Copy link
Contributor

This bumps Lottie to 3.0.6 and also reformats the podspec file using a Ruby linter. Let me know I should revert that change

@buba447 @Coeur

@thedrick
Copy link
Contributor Author

I verified that this builds correctly for iOS, MacOS, and TvOS using CocoaPods and Carthage

@Coeur
Copy link
Contributor

Coeur commented May 14, 2019

Hello,
Yes, it builds and could be merged, but note that:

  • I'm not a fan of the %w syntax, as it means our eyes have to read multiple syntaxes for the same thing (%w when array elements don't have any space, and classic single quotes for other arrays)
  • The commit also introduces a mix of syntaxes between s.license and s.author: one uses symbol: value and the other uses key => value.
    Sure, overall we use less characters, but perhaps we shouldn't make it harder for Ruby neophytes.

@thedrick
Copy link
Contributor Author

@Coeur sounds good to me, I'll revert those changes

@thedrick
Copy link
Contributor Author

@Coeur updated!

@buba447 buba447 merged commit fc01fd6 into master May 14, 2019
@thedrick thedrick deleted the thedrick-bump-3.0.6 branch May 14, 2019 17:31
calda pushed a commit that referenced this pull request Nov 28, 2022
calda pushed a commit that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants