Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AnimatedControl to set a value provider #857

Merged

Conversation

thephamiliar
Copy link
Collaborator

In order to change the colors at runtime for AnimatedControl, we need to expose a method so that the private animatedView can set its value provider.

Main changes are in: d5f1ae0

cc: @thedrick

Copy link
Contributor

@thedrick thedrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for adding this!

@buba447 I wonder if we should keep this approach or just expose the animatedView as a public let?

@thedrick
Copy link
Contributor

Lets merge this through and we can make updates in the future if we feel this isn't sufficient. thanks for adding this @thephamiliar

@thedrick thedrick merged commit 5a17497 into airbnb:master Apr 11, 2019
@DennisWeirauch
Copy link

Why is the animationView not exposed from AnimatedControl? I need access to the textProvider from an AnimatedSwitch (with a label indicating the current state "on"/"off").

As there are numerous other cases where properties of the AnimationView need to be accessed from AnimatedControls, the obvious solution would be to directly expose it. Is there a reason not to do so?

NSGolova pushed a commit to clario-tech/lottie-ios that referenced this pull request Nov 19, 2020
…imated-control

Allow AnimatedControl to set a value provider
calda pushed a commit that referenced this pull request Dec 1, 2022
…-control

Allow AnimatedControl to set a value provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants