Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better support for negative animation speeds #377

Merged
merged 7 commits into from
Aug 17, 2017
Merged

Add better support for negative animation speeds #377

merged 7 commits into from
Aug 17, 2017

Commits on Aug 17, 2017

  1. Add better support for negative animation speeds 

    - The progress can be calculated basd on negative speed
  + The end frame would be a progress of 0 and the start frame a progress of 1
  + Recalculate progress when the speed changes, otherwise a "jump" will be seen when restarting animation

- The frame for the progress can be calculated using the newly inverted progress
  + Determine the absolute progress based on current progress and determine which frame to use based on animation speed

- This fixes issues of animations playing with negative speeds "bouncing" back to their final position
  which was caused by the final frame being calculated based on a completed progress of 1 which then did not take into
  account the negative animation speed.
    @welshm
    welshm committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    a53bbe9 View commit details
    Browse the repository at this point in the history

  2. Add better support for negative animation speeds 

    - The progress can be calculated basd on negative speed
  + The end frame would be a progress of 0 and the start frame a progress of 1
  + Recalculate progress when the speed changes, otherwise a "jump" will be seen when restarting animation

- The frame for the progress can be calculated using the newly inverted progress
  + Determine the absolute progress based on current progress and determine which frame to use based on animation speed

- This fixes issues of animations playing with negative speeds "bouncing" back to their final position
  which was caused by the final frame being calculated based on a completed progress of 1 which then did not take into
  account the negative animation speed.
    @welshm
    welshm committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    3e0790a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'reverseSupport' of https://github.com/welshm/lottie-ios … 

    …into reverseSupport
    @welshm
    welshm committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    0896678 View commit details
    Browse the repository at this point in the history

  4. Revert some of the animationProgress changes to revert to reflect abs… 

    …olutes

- Update header documentation to make it clear how animatinoSpeed and animationProgress interact
- Leave fixes in there that stop reversed animations "snapping" back
    @welshm
    welshm committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    ab75236 View commit details
    Browse the repository at this point in the history

  5. Rename _isPlayingForward to _isSpeedNegative to be more clear what it… 

    …'s checking
    @welshm
    welshm committed Aug 17, 2017
    2 Configuration menu
    Copy the full SHA
    b0b7b7c View commit details
    Browse the repository at this point in the history

  6. Update LOTAnimationView header to have better comments

    @welshm
    welshm committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    805a671 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into reverseSupport

    @buba447
    buba447 committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    fbf6ca5 View commit details
    Browse the repository at this point in the history