Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lottie] Support drop shadow in main thread engine #2423

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

1an-xu
Copy link
Contributor

@1an-xu 1an-xu commented Jun 8, 2024

This PR mostly follows @calda 's change in CA engine, to render drop shadow in main thread engine

Main thread - Before Main thread - After CA Engine
effect simulator_screenshot_38A3E3D6-D4D7-4E03-A3FE-1DA3CB144653 simulator_screenshot_9CE5EA30-83EA-4AE8-8FA6-1D0286CC3FEA simulator_screenshot_4A46A642-9D95-46F2-A2E6-12B9C6F86DCF
animation Simulator Screen Recording - iPhone 15 Pro Max - 2024-06-08 at 20 25 52 Simulator Screen Recording - iPhone 15 Pro Max - 2024-06-08 at 20 21 27 Simulator Screen Recording - iPhone 15 Pro Max - 2024-06-08 at 20 22 20

@1an-xu 1an-xu changed the title support drop shadow [Lottie] Support drop shadow in main thread engine Jun 9, 2024
@1an-xu 1an-xu marked this pull request as ready for review June 9, 2024 03:29
Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @1an-xu! Looks great!

@calda
Copy link
Member

calda commented Jun 10, 2024

I made a couple of small tweaks:

  • Disabled implicit CALayer animations for these new shadow-related properties: 35756c4 (otherwise there can be a short unexpected flash where the shadows fade in with a short animation)
  • Updated a smaller set of snapshot images: 332ecab

Otherwise looks perfect! Thank you very much for taking the time to add this 🙇🏻

@calda calda enabled auto-merge (squash) June 10, 2024 16:35
@calda calda merged commit fca6f33 into airbnb:master Jun 10, 2024
12 checks passed
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Jul 10, 2024
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor |
`from: "4.4.3"` -> `from: "4.5.0"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.5.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.5.0)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.3...4.5.0)

#### New Features

- Added drop shadow support to main thread rendering engine
([airbnb/lottie-ios#2423)
- Added support for opacity text animators
([airbnb/lottie-ios#2436)
- Added `LottieView` helper for configuring individual
`LottieAnimationView` properties
([airbnb/lottie-ios#2415)

#### Bug Fixes

- Fixed issue where bezier paths could be closed incorrectly
([airbnb/lottie-ios#2418)
- Fixed bug where font providers were ignored in precomposition layers
in the main thread rendering engine
([airbnb/lottie-ios#2439)
- Fixed issue where lottie-spm package could cause package operations to
unexpectedly fail on Linux
([airbnb/lottie-spm#27).

#### Version Compatibility

**Lottie now requires Xcode 15 / Swift 5.9 or later**
([airbnb/lottie-ios#2400).
Our version support policy is that Lottie supports Swift / Xcode
versions back to the minimum version that is permitted by Apple for
submissions to the App Store. As of April 2024, this is Xcode 15 / Swift
5.9: https://developer.apple.com/news/?id=fxu2qp7b.

**Full Changelog**:
airbnb/lottie-ios@4.4.3...4.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants