Fix issue where animation size could be incorrect after loading async animation #2379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the view's size could be incorrect after loading an async animation.
I believe this issue was introduced by #2289, when we changed the lifecycle of the
LottieAnimationView
. Previously it was only added to the view hierarchy after the animation finished loading. Now it's always present, so can have an intrinsic size of zero if measured before the async animation finishes loading.Here's the sample code I added to test this case. The async case was broken before. Now both work as expected.
Before
After