Reduce log volume from warning about After Effects expressions #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-jimenez-0529
approved these changes
Sep 20, 2023
|
I love the point free snapshot testing library, especially for text output. Super easy! |
calda
added a commit
that referenced
this pull request
Sep 20, 2023
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the log volume created by our warnings about unsupported After Effects expressions.
#2191 mentioned that these logs are a bit excessive. This has also come up within Airbnb, where this is creating quite a lot of noise in our CI jobs.
Instead of printing this for each instance of AE expressions, we can instead just print it once per animation. We can also remove the code from the log message, since the code is potentially very long and doesn't actually contribute much to the log message.
4f88cbe sets up snapshot tests for our log output.
a9628a3 then actually changes the log output for After Effects expressions, and updates the log output snapshot. You can see much less is logged in the diff for that commit: