Fix bounds calculation for masked sublayers #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks likely this will fix #198, although it's hard to be certain without a specific example. |
NSGolova
pushed a commit
to clario-tech/lottie-ios
that referenced
this pull request
Nov 19, 2020
Fix bounds calculation for masked sublayers
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
Fix bounds calculation for masked sublayers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where views added via
addSublayer:toLayerNamed:would receive incorrect frames.It looks like when the bounds calculation for
LOTCustomChildwas moved fromLOTAnimationViewtoLOTCompositionLayerin #110, the reference layer for the bounds of the child layer didn't get updated correctly. This is visible in the sample transition animations included withlottie-ios-Example.Additionally, this removes the mask layer from its superlayer, as CALayer.mask's docs say
The layer you assign to this property must not have a superlayer. If it does, the behavior is undefined.Before:
After: