Add info about lottie-spm repo #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Jan 18, 2023
| @@ -71,29 +75,6 @@ carthage update | |||
| ``` | |||
| In your application targets “General” tab under the “Linked Frameworks and Libraries” section, drag and drop lottie-ios.framework from the Carthage/Build/iOS directory that `carthage update` produced. | |||
|
|
|||
| ### Binary dependency (`xcframework`) | |||
There was a problem hiding this comment.
I don't think we need to recommend this approach anymore, since it was primarily a workaround for the large repo size when using SPM. I think the UX for integrating with the lottie-spm repo is much better than manually managing XCFrameworks / checksums. Using lottie-spm also probably makes it easier for folks to stay up-to-date (since the standard swift package update flow still works).
|
ptal @erichoracek |
erichoracek
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
@calda LGTM! Frustrating that we need to use this workaround, it would be good to elevate this to the SPM folks in some form
|
I filed an issue on SPM here: swiftlang/swift-package-manager#6062 |
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information about the new lottie-spm repo. I think it makes sense for this to be the recommended way to integrate Lottie via Swift Package Manager.
I'll release 4.1.0 after merging this PR.