Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gradients with alpha values #1634

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Add support for gradients with alpha values #1634

merged 5 commits into from
Jul 7, 2022

Conversation

calda
Copy link
Member

@calda calda commented Jul 7, 2022

This PR adds support for gradients with alpha values. Previously we silently ignored these alpha values. Fixes #1628.

Before After
Simulator Screen Shot - iPhone 12 Pro Max - 2022-07-07 at 08 55 57 Simulator Screen Shot - iPhone 12 Pro Max - 2022-07-07 at 09 20 07

Copy link
Contributor

@thedrick thedrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @calda

@calda calda enabled auto-merge (squash) July 7, 2022 16:53
Comment on lines +140 to +141
// Alpha values aren't stored contiguously with the RGB color components,
// but are instead optionally listed at the end of the array
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha that's fun one 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatic renderingEngine in AnimationView not rendering gradients properly
3 participants