Add logHierarchyKeypaths() support to Core Animation rendering engine
#1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichoracek
approved these changes
Jul 5, 2022
7f105c5
to
1b4aa2a
Compare
1b4aa2a
to
b7c931a
Compare
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
logHierarchyKeypaths()onCoreAnimationLayer. Previously it was unimplementation and calling it was a no-op. Fixes #1623.I also added some snapshot tests for the output of this method, on both the Main Thread and Core Animation rendering engines.