Set up GitHub actions to run Swift linter in CI #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks currently fail, which suggests everything is set up correctly:
Will push a commit that runs |
|
Nice, checks pass now!
|
calda
added a commit
that referenced
this pull request
Dec 7, 2021
Add linter configuration from airbnb/swift Add Rakefile with lint and format commands Add Mintfile to specify SwiftFormat and SwiftLint dependency versions bundle install Add GitHub Action step that runs linter Udpdate Rakefile to lint lottie-swift folder Run linter Run linter Fix Rakefile Run SwiftLint on Example folder Fix lint-only SwiftLint violations
e4207b4
to
8e2bc5c
Compare
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards setting up GitHub Actions for this repo.
This PR specifically integrates SwiftFormat and SwiftLint, following the pattern used by airbnb/epoxy-ios (
bundle exec rake lint:swift/bundle exec rake format:swiftto lint or format, which invokes SwiftFormat and SwiftLint usingmint run).