Changed ACL for animationView to public in AnimatedControl #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buba447
approved these changes
Aug 5, 2020
calda
pushed a commit
that referenced
this pull request
Nov 28, 2022
Changed ACL for animationView to public in AnimatedControl
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
Changed ACL for animationView to public in AnimatedControl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous cases where properties of the
AnimationViewwithin anAnimatedControlneed to be accessed. I needed to add atextProviderto add localized strings to a custom switch with labels for the different states.Instead of exposing every single property separately (like it is done with the
animationSpeedor setting thevalueProvider), a more convenient way is to simply expose theanimationViewto the public.