Improve animation view #1114
Merged
Improve animation view #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Apple's documentation, this method invocation should not be needed anymore. ``` If your app targets iOS 9.0 and later or macOS 10.11 and later, you don't need to unregister an observer in its dealloc method. ```
Don't invoke any state updates when both the `window` and the `superview` is `nil`
emrcftci
reviewed
Jan 23, 2020
| /// Don't update any state if both the `superview` and `window` is `nil` | ||
| guard window != nil && superview != nil else { | ||
| return | ||
| } |
There was a problem hiding this comment.
Please use early-return instead of new lines.
guard window != nil && superview != nil else { return }
There was a problem hiding this comment.
Hey @emrcftci, pushed another commit fixing the syntax :)
|
It looks good for me PTAL @buba447 |
|
LGTM! Nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeObservercall inAnimationView.deinitanimationMovedToWindow()to ensure that state change don't happen to orphanAnimationView'sReference issue: #1113