Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case with target content offset #117

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

bryankeller
Copy link
Contributor

Details

This is a follow-up to #116 - I realized that we don't want to do target content offset logic whenever the bounds changes (it changes when the content offset changes). We only want to handle target content offset if the size changes.

Related Issue

N/A

Motivation and Context

Fixing edge cases

How Has This Been Tested

Example app, Airbnb app

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the bug Something isn't working label Feb 14, 2024
Copy link

@brynbodayle brynbodayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch

@bryankeller bryankeller merged commit 27f75a0 into master Feb 14, 2024
2 checks passed
@bryankeller bryankeller deleted the bk/target-content-offset-improvements-2 branch February 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants