Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websocket connection leak #7978

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Fix websocket connection leak #7978

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ada0061
Fix websocket connection leak
bdraco Dec 17, 2023
56fe7eb
fix: missed one
bdraco Dec 17, 2023
dd4c3b4
never let it leak
bdraco Dec 17, 2023
94076ca
Revert "never let it leak"
bdraco Dec 17, 2023
3c90f16
document autoclose=False leaks
bdraco Dec 17, 2023
d47d0d4
timeline
bdraco Dec 17, 2023
a3f925e
coverage
bdraco Dec 18, 2023
a9754ea
speed up test
bdraco Dec 18, 2023
f14c0bd
speed up test
bdraco Dec 18, 2023
98564bf
speed up test
bdraco Dec 18, 2023
43d10be
speed up test
bdraco Dec 18, 2023
dab76ca
speed up test
bdraco Dec 18, 2023
d0b459d
Merge branch 'master' into fix_ws_close
bdraco Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
document autoclose=False leaks
  • Loading branch information
@bdraco
bdraco committed Dec 17, 2023
commit 3c90f16fe12153cce26cf5f4bc7d123d494a5cfe
8 changes: 8 additions & 0 deletions docs/web_reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,14 @@ and :ref:`aiohttp-web-signals` handlers::

.. versionadded:: 3.3

:param bool autoclose: Close connection when the client sends
a :const:`~aiohttp.WSMsgType.CLOSE` message,
``True`` by default. If set to ``False``,
the connection is not closed and the
caller is responsible for calling
``request.transport.close()`` to avoid
leaking resources.


The class supports ``async for`` statement for iterating over
incoming messages::
Expand Down
Loading