make new resources classes public

[rutsky]

These classes are documented as members of aiohttp.web, but they aren't because they are not exported in __all__:
AbstractResource, ResourceAdapter, AbstractRoute, ResourceRoute.

[asvetlov]

I just curious what do you want to do with these public names? Perform isinstance() checks?
Creating new resources is still forbidden by public API, the only available way is router.add_resource().

[rutsky]

I just curious what do you want to do with these public names? Perform isinstance() checks?

1. For type hinting (e.g. here, however I removed them at this moment because of this issue).
2. For isinstance checks, yes.

I haven't thought about support of Resources in aiohttp_cors in details, but I believe in addition to:

# setup CORS for specific route
cors.add(app.router.add_route("GET", "/hello", handler_get))

where cors.add() receives AbstractRoute.
Will be cors.add() that receives AbstractResource:

resource = router.add_resource('/path/{to}', name='name')
resource.add_route('GET', handler_get)
resource.add_route('POST', handler_post)
# setup CORS for all routes on resource
cors.add(resource)

So I need to check is passed object is resource or route.

Currently later approach is not supported, but RuntimeError after proper isinstance check is already done: https://github.com/aio-libs/aiohttp_cors/blob/fix-for-aiohttp-0.21/aiohttp_cors/cors_config.py#L172

[asvetlov]

Sounds good

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.