Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type of Resource.__iter__() #6460

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Dec 27, 2021

_routes doesn't declare the type as AbstractRoute, so we should match it in __iter__().

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels Dec 27, 2021
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #6460 (55557a5) into master (eda8114) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6460   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         104      104           
  Lines       30484    30484           
  Branches     3067     3067           
=======================================
  Hits        28457    28457           
  Misses       1850     1850           
  Partials      177      177           
Flag Coverage Δ
unit 93.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 97.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda8114...55557a5. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit 24af37c into master Dec 27, 2021
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-3 branch December 27, 2021 17:43
@patchback
Copy link
Contributor

patchback bot commented Dec 27, 2021

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/24af37c300006d9d7e05d0054ec820ee479d9f44/pr-6460

Backported as #6461

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 27, 2021
Dreamsorcerer added a commit that referenced this pull request Dec 27, 2021
(cherry picked from commit 24af37c)

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant