Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use md5 checksums instead of file timestamps #5166

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Use md5 checksums instead of file timestamps #5166

merged 4 commits into from
Oct 28, 2020

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Oct 28, 2020

It allows more reliable rebuilding C extensions on jumping between aiohttp versions

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #5166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5166   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files          43       43           
  Lines        8779     8779           
  Branches     1412     1412           
=======================================
  Hits         8556     8556           
  Misses        112      112           
  Partials      111      111           
Flag Coverage Δ
#unit 97.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e615ad9...d584a38. Read the comment docs.

@asvetlov asvetlov marked this pull request as ready for review October 28, 2020 16:36
@asvetlov asvetlov merged commit fe30265 into master Oct 28, 2020
@asvetlov asvetlov deleted the checksums branch October 28, 2020 16:56
@github-actions
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.7: Commit could not be cherrypicked due to conflicts
  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

@asvetlov
Copy link
Member Author

Backported manually

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants