Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix run_app typing (#4957) #5114

Merged
merged 2 commits into from
Oct 24, 2020
Merged

fix run_app typing (#4957) #5114

merged 2 commits into from
Oct 24, 2020

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Oct 24, 2020

What do these changes do?

Fix typing of run_app function

Are there changes in behavior for the user?

No

Related issue number

#4957

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@derlih derlih requested a review from asvetlov as a code owner October 24, 2020 14:19
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #5114 into master will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5114      +/-   ##
==========================================
- Coverage   97.50%   97.07%   -0.44%     
==========================================
  Files          43       43              
  Lines        8821     8822       +1     
  Branches     1414     1414              
==========================================
- Hits         8601     8564      -37     
- Misses        103      136      +33     
- Partials      117      122       +5     
Flag Coverage Δ
#unit 97.07% <100.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 97.45% <100.00%> (+0.02%) ⬆️
aiohttp/web_runner.py 92.44% <0.00%> (-5.34%) ⬇️
aiohttp/tcp_helpers.py 94.73% <0.00%> (-5.27%) ⬇️
aiohttp/pytest_plugin.py 92.50% <0.00%> (-5.00%) ⬇️
aiohttp/connector.py 94.88% <0.00%> (-1.92%) ⬇️
aiohttp/web_protocol.py 91.40% <0.00%> (-0.86%) ⬇️
aiohttp/test_utils.py 99.06% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f388797...1ce9841. Read the comment docs.

@asvetlov asvetlov merged commit 0e79469 into aio-libs:master Oct 24, 2020
@asvetlov
Copy link
Member

Thanks!

@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.7: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants