Added IPv6 address support in ClientRequest.update_host #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,41 +97,45 @@ def __init__(self, method, url, *, | |||
|
|
|||
| def update_host(self, url): | |||
| """Update destination host, port and connection type (ssl).""" | |||
| scheme, netloc, path, query, fragment = urllib.parse.urlsplit(url) | |||
| scheme, netloc, path, query, fragment = \ | |||
| url_parsed = urllib.parse.urlsplit(url) | |||
There was a problem hiding this comment.
Please make code simpler:
url_parsed = urllib.parse.urlsplit(url)
scheme, netloc, path, query, fragment = url_parsed
One-liners are not always the best solution.
There was a problem hiding this comment.
Or even drop second line from my previous comment and use url_parsed everywhere in the method.
asvetlov
added a commit
that referenced
this pull request
Jun 26, 2015
Added IPv6 address support in ClientRequest.update_host
|
Perfect! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of aiohttp doesn't support ipv6 addresses in url (like http:https://[2001:db8::1]/). It fails with exception here.
This pull request should fix it.