Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client response #1733

Merged
merged 7 commits into from
Mar 21, 2017
Merged

Client response #1733

merged 7 commits into from
Mar 21, 2017

Conversation

penguinolog
Copy link
Contributor

What do these changes do?

Attach request_info to response object

Are there changes in behavior for the user?

Possible to get request url and headers from response object.

Related issue number

#1705

@fafhrd91
Copy link
Member

could you modify ClientResponseError and add request_info to this exception in raise_for_status

@penguinolog
Copy link
Contributor Author

Ok, I'll do it tomorrow.

@fafhrd91
Copy link
Member

Awesome

@fafhrd91 fafhrd91 force-pushed the master branch 2 times, most recently from 7c97b03 to 37c97b8 Compare March 20, 2017 19:46
@penguinolog
Copy link
Contributor Author

Last travis run: 1 job fail was produced by different reason (asyncio failure).

@codecov-io
Copy link

Codecov Report

Merging #1733 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
+ Coverage   96.77%   96.77%   +<.01%     
==========================================
  Files          37       37              
  Lines        7438     7444       +6     
  Branches     1296     1296              
==========================================
+ Hits         7198     7204       +6     
  Misses        111      111              
  Partials      129      129
Impacted Files Coverage Δ
aiohttp/client_exceptions.py 100% <100%> (ø) ⬆️
aiohttp/client_reqrep.py 95.73% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 198ff33...9114e3f. Read the comment docs.

@fafhrd91
Copy link
Member

awesome! thanks

@fafhrd91 fafhrd91 closed this Mar 21, 2017
@fafhrd91 fafhrd91 merged commit 8662357 into aio-libs:master Mar 21, 2017
@penguinolog penguinolog deleted the ClientResponse branch March 21, 2017 17:11
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants