Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement timeout for server-side web sockets #1024

Closed
asvetlov opened this issue Jul 31, 2016 · 3 comments
Closed

Implement timeout for server-side web sockets #1024

asvetlov opened this issue Jul 31, 2016 · 3 comments
Labels
outdated

Comments

@asvetlov
Copy link
Member

Constructor parameter.
Should be None (disabled) by default.
If there is no activity from client-side peer for timeout seconds -- terminate the connection.
@asvetlov
Copy link
Member Author

asvetlov commented Aug 1, 2016

Write a doc describing why TCP transport has no guarantees for delivering socket disconnection event and why sending client-side pings (by ping frame or explicit message) is crucial for making connection reliable.

@rutsky rutsky mentioned this issue Jan 31, 2017
Closed
fafhrd91 pushed a commit that referenced this issue Jan 31, 2017
Added receive_timeout timeout for websocket to receive complete messa…
a69ea90 
…ge. #1024 #1325
fafhrd91 pushed a commit that referenced this issue Feb 1, 2017
Added autoping_interval parameter for websocket to automatically send…
aedc79e 
… ping message. #1024 #777
@fafhrd91
Copy link
Member

fafhrd91 commented Feb 1, 2017

implemented in master

@fafhrd91 fafhrd91 closed this as completed Feb 1, 2017
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @fafhrd91