Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor of backend code #702

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Minor refactor of backend code #702

merged 2 commits into from
Apr 30, 2023

Conversation

Dreamsorcerer
Copy link
Member

Minor refactor to move some code from the SQLAlchemy backend to the base class so it can be reused.

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #702 (4490246) into master (665dfb8) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   97.56%   97.66%   +0.10%     
==========================================
  Files          14       14              
  Lines        1927     1926       -1     
  Branches      307      308       +1     
==========================================
+ Hits         1880     1881       +1     
+ Misses         23       22       -1     
+ Partials       24       23       -1     
Flag Coverage Δ
unit 97.61% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp_admin/backends/abc.py 95.91% <100.00%> (+0.12%) ⬆️
aiohttp_admin/backends/sqlalchemy.py 88.18% <100.00%> (+0.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit fa287a2 into master Apr 30, 2023
@Dreamsorcerer Dreamsorcerer deleted the py-cleanup branch April 30, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant