Add MsgPackSerializer-related acceptance tests #836
Conversation
| async def test_set_get_types(self, cache, obj): | ||
| cache.serializer = MsgPackSerializer() | ||
| assert await cache.set(Keys.KEY, obj) is True | ||
| assert await cache.get(Keys.KEY) == msgpack.loads(msgpack.dumps(obj)) |
There was a problem hiding this comment.
I think some of the failures are related to the test itself (specifically msgpack.loads(msgpack.dumps(obj)))?
https://github.com/aio-libs/aiocache/actions/runs/8513779973/job/23320587633?pr=836#step:7:82
There was a problem hiding this comment.
I don't think the test itself is causing issues here; adding
assert msgpack.loads(msgpack.dumps(obj)) == objright before the other asserts in TestMsgPackSerializer doesn't raise any error.
My guess would be that TypeError: a bytes-like object is required, not 'str' is raised because of the same encoding issues as the UnicodeDecodeError ones. But it's not raised by msgpack itself, that's for sure.
There was a problem hiding this comment.
My guess would be that
TypeError: a bytes-like object is required, not 'str'is raised because of the same encoding issues as theUnicodeDecodeErrorones. But it's not raised by msgpack itself, that's for sure.
That's the one I was linking to. ;)
This pull request adds acceptance tests for
MsgPackSerializerwhich were lacking from the current test-suite.They will break CI since there's currently issues when using
MsgPackSerializeras the serializer, which these tests are here to catch.See issue #834.