Instances are reused if same kwargs are used. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a singleton-like pattern, instances are reused if same kwargs are passed this means connections are also reused. It also introduces a pattern that if an instance is changed, other ones will also be changed but this is wanted because once initialized instances must behave as readonly
If a pool is called with the same args as a previous one, it will be reused
0c5ae39
to
26643f1
Compare
Current coverage is 100% (diff: 100%)@@ master #77 diff @@
===================================
Files 11 11
Lines 485 488 +3
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 485 488 +3
Misses 0 0
Partials 0 0
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a singleton-like pattern, instances are reused if same kwargs are passedthis means connections are also reused. It also introduces a pattern that
if an instance is changed, other ones will also be changed but this is wanted
because once initialized instances must behave as readonly
Save pool instances in RedisBackend and reuse them in case same args are used.
Closes #45
Closes #76