Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typehints in lock.py #434

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Improve typehints in lock.py #434

merged 2 commits into from
Jan 9, 2019

Conversation

aviv-ebates
Copy link
Contributor

  • The constructors take an instance of type BaseCache, not Type[]
  • Mypy doesn't consider True to be a type.

@argaen
Copy link
Member

argaen commented Jan 8, 2019

thanks @aviv-ebates! can you fix the syntax errors? no need to import the Type class anymore

@aviv-ebates
Copy link
Contributor Author

hey @argaen , I've fixed the import, but it kinda looks like the tests are broken with unknown hook 'pytest_namespace'....

@argaen
Copy link
Member

argaen commented Jan 8, 2019

Oh wow, seems tests started failed since yesterday, probably a rogue dependency for testing. Will check and then rebase this branch with master then to see if build passes

aviv-ebates and others added 2 commits January 9, 2019 00:17
- The constructors take an instance of type `BaseCache`, not `Type[]`
- Mypy doesn't consider `True` to be a type.
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #434 into master will decrease coverage by 63.64%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #434       +/-   ##
===========================================
- Coverage   99.77%   36.12%   -63.65%     
===========================================
  Files          10       10               
  Lines         894      894               
  Branches       96       96               
===========================================
- Hits          892      323      -569     
- Misses          2      571      +569
Impacted Files Coverage Δ
aiocache/lock.py 36.53% <100%> (-63.47%) ⬇️
aiocache/decorators.py 18.75% <0%> (-81.25%) ⬇️
aiocache/backends/memcached.py 25% <0%> (-75%) ⬇️
aiocache/backends/memory.py 28.39% <0%> (-71.61%) ⬇️
aiocache/factory.py 32.87% <0%> (-67.13%) ⬇️
aiocache/backends/redis.py 34.66% <0%> (-65.34%) ⬇️
aiocache/base.py 49.57% <0%> (-50.43%) ⬇️
aiocache/serializers.py 57.89% <0%> (-38.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62e564...d12d25f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #434 into master will decrease coverage by 63.64%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #434       +/-   ##
===========================================
- Coverage   99.77%   36.12%   -63.65%     
===========================================
  Files          10       10               
  Lines         894      894               
  Branches       96       96               
===========================================
- Hits          892      323      -569     
- Misses          2      571      +569
Impacted Files Coverage Δ
aiocache/lock.py 36.53% <100%> (-63.47%) ⬇️
aiocache/decorators.py 18.75% <0%> (-81.25%) ⬇️
aiocache/backends/memcached.py 25% <0%> (-75%) ⬇️
aiocache/backends/memory.py 28.39% <0%> (-71.61%) ⬇️
aiocache/factory.py 32.87% <0%> (-67.13%) ⬇️
aiocache/backends/redis.py 34.66% <0%> (-65.34%) ⬇️
aiocache/base.py 49.57% <0%> (-50.43%) ⬇️
aiocache/serializers.py 57.89% <0%> (-38.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62e564...d12d25f. Read the comment docs.

@argaen argaen merged commit 44b15dd into aio-libs:master Jan 9, 2019
@aviv-ebates aviv-ebates deleted the patch-1 branch January 9, 2019 09:00
@aviv-ebates
Copy link
Contributor Author

thanks!

@argaen
Copy link
Member

argaen commented Jan 9, 2019

thanks for the contribution! :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants