Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add the ability to view metric min/max/first values in Runs Explorer #3094

Conversation

KaroMourad
Copy link
Contributor

@KaroMourad KaroMourad commented Jan 18, 2024

  • Added dropdown to select which metric value (min/max/first/last) you want to see in Runs table

@KaroMourad KaroMourad self-assigned this Jan 18, 2024
@KaroMourad KaroMourad changed the base branch from main to feature/improve-app-model-methods January 18, 2024 08:15
@KaroMourad
Copy link
Contributor Author

Resolve: #1971

Base automatically changed from feature/improve-app-model-methods to main January 19, 2024 07:55
@KaroMourad KaroMourad marked this pull request as ready for review January 19, 2024 09:13
@KaroMourad KaroMourad changed the title [feat] Add the ability to view metric min and max values in Runs Explorer [feat] Add the ability to view metric min/max/first values in Runs Explorer Jan 19, 2024
@KaroMourad KaroMourad marked this pull request as draft January 22, 2024 17:19
@KaroMourad KaroMourad marked this pull request as ready for review January 23, 2024 20:52
@KaroMourad KaroMourad force-pushed the feature/add-ability-to-view-metric-min-max-values-in-runs-explorer branch from 030667d to 3cc4cfb Compare January 23, 2024 20:56
Copy link
Contributor

@mihran113 mihran113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberttorosyan alberttorosyan changed the base branch from main to release/3.18.x February 6, 2024 18:23
…alues-in-runs-explorer

# Conflicts:
#	CHANGELOG.md
@KaroMourad KaroMourad force-pushed the feature/add-ability-to-view-metric-min-max-values-in-runs-explorer branch from 514df1f to 4f86964 Compare February 6, 2024 19:07
@KaroMourad KaroMourad merged commit 6203298 into release/3.18.x Feb 6, 2024
2 of 3 checks passed
@KaroMourad KaroMourad deleted the feature/add-ability-to-view-metric-min-max-values-in-runs-explorer branch February 6, 2024 19:09
@Pyrestone
Copy link

Thanks @KaroMourad for implementing this!
As I already mentioned in #1971 though, this feature only really becomes useful if we can select min/max/first/last on a per-column-basis, as it was initially described in the feature request.

This is because some metrics are minimum-focused, such as loss, and others such as accuracy are maximum-focused, and for others still, such as step counters only the last value is important.
It would be really useful to be able to visualize all of this at the same time instead of alternating between four different views to gather this information.

@KaroMourad Do you think you could modify the implementation such that this becomes possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants