[feat] Add ability for TensorboardFolderTracker to track Tensorboard Histogram's as Aim Distribution's
#2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into alan/tensorboard_histograms
|
Hey @alansaul! Looks great to me. Will merge to main, then manually transfer to the |
mihran113
approved these changes
May 30, 2023
mihran113
pushed a commit
that referenced
this pull request
May 30, 2023
…d `Histogram`'s as Aim `Distribution`'s (#2719) # Conflicts: # CHANGELOG.md # tests/ext/test_tensorboard_tracker.py
|
#2797 here is the link for the PR to the |
mihran113
added a commit
that referenced
this pull request
May 30, 2023
…d `Histogram`'s as Aim `Distribution`'s (#2719) # Conflicts: # CHANGELOG.md # tests/ext/test_tensorboard_tracker.py
mihran113
pushed a commit
that referenced
this pull request
May 30, 2023
…d `Histogram`'s as Aim `Distribution`'s (#2719) # Conflicts: # CHANGELOG.md # tests/ext/test_tensorboard_tracker.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation to also allow Tensorboard
histogram's to be tracked as AimDistribution's.I have only user-tested the plugin based version, but have added unit-tests following a similar testing methodology as #2669 (using torch's utilities for tensorboard events) for both the tensorboard histogram plugin and non-plugin implementations.
histogram->Distributionconversionhistogramplugin ->DistributionconversionResolves: #2718