Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use encoder/decoder call directly #2366

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Use encoder/decoder call directly #2366

merged 2 commits into from
Nov 13, 2023

Conversation

AnnaKwa
Copy link
Contributor

@AnnaKwa AnnaKwa commented Nov 8, 2023 •
edited
Loading

Making a separate PR using @frodre 's commit that greatly speeds up training.
Directly calling the encoder vs .predict reduces batch fitting time by >2-10x.

frodre
frodre approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@frodre frodre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad it sped up your training too!

@AnnaKwa AnnaKwa merged commit a47261e into master Nov 13, 2023
13 of 14 checks passed
@AnnaKwa AnnaKwa deleted the encoder-speed-fix branch November 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodre frodre frodre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnnaKwa @frodre