Bump SHiELD_physics and atmos_drivers
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @brianhenn — in porting the surface type fraction diagnostics over from FV3GFS I neglected to test compiling things in mixed 32-bit / 64-bit mode, and missed a spot where It's not important for the wrapper at the moment since we do not support wrapping a mixed mode model, but it would make me feel better to have this feature implemented fully correctly in this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the versions of the
SHiELD_physicsandatmos_driversrepositories following NOAA-GFDL/SHiELD_physics#35, NOAA-GFDL/SHiELD_physics#36, NOAA-GFDL/SHiELD_physics#37, and NOAA-GFDL/atmos_drivers#32; these PRs fix a bug in loading a Q-flux from a file and add surface type fraction diagnostics (like in ai2cm/fv3gfs-fortran#377). In doing so this PR adds regression test coverage for diagnostics manager controlled physics diagnostics, to ensure that these continue operating properly as theSHiELD_physicscode evolves.We first add a diagnostics manager controlled field to the regression test and update the checksums, then update the submodules to ensure that the updates do not modify this existing field, and finally add the surface type fraction fields.