Fix forwarded IP comparison in login-ip plugin

The issue described in vrana#372 is the same for the HTTP_X_FORWARDED_FOR comparison. strncasecmp returns 0 when the two strings are equal which is falsey.
ahmadfikrimasyhur · Feb 4, 2020 · 3f38b61 · 3f38b61
1 parent 9ab2057
commit 3f38b61
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/plugins/login-ip.php b/plugins/login-ip.php
@@ -29,7 +29,7 @@ function login($login, $password) {
  }
  if ($_SERVER["HTTP_X_FORWARDED_FOR"]) {
  foreach ($this->forwarded_for as $forwarded_for) {
- if (strncasecmp(preg_replace('~.*, *~', '', $_SERVER["HTTP_X_FORWARDED_FOR"]), $forwarded_for, strlen($forwarded_for))) {
+ if (strncasecmp(preg_replace('~.*, *~', '', $_SERVER["HTTP_X_FORWARDED_FOR"]), $forwarded_for, strlen($forwarded_for)) == 0) {
  return true;
  }
  }