Shutdown the loop's default thread executor at the end of a test #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinbarczynski
force-pushed
the
shutdown-loop-executor-in-tests
branch
3 times, most recently
from
0c4755a
to
a10c49c
Compare
|
Surely there is a way to do this on Pythons earlier than 3.9, even if we have to use a private API? |
That's true, but it requires copying non-trivial code from Python 3.9+ to anyio and adapting it to Python 3.7 and 3.8 internals. Do you think it's worth the effort? |
|
Yeah, those Python versions will stay supported for a while. Also please add a regression test. |
marcinbarczynski
force-pushed
the
shutdown-loop-executor-in-tests
branch
5 times, most recently
from
56f7777
to
ecd414c
Compare
The same approach is adopted in IsolatedAsyncioTestCase. It prevents leaking asyncio threads as loop.close() doesn't join them. BaseEventLoop.shutdown_default_executor was introduced in Python 3.9. For earlier versions, this commit introduces an adapted version of the method: _shutdown_default_executor. However, it doesn't work with uvloop < 0.15.0 because, uvloop doesn't expose _default_executor attribute. It's rather a minor issue as uvloop 0.15.0 is 2 years old - in such case this commit is a no-op. Fixes agronholm#503
marcinbarczynski
force-pushed
the
shutdown-loop-executor-in-tests
branch
from
ecd414c
to
904aaba
Compare
Done. |
agronholm
approved these changes
Nov 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same approach is adopted in IsolatedAsyncioTestCase. It prevents leaking asyncio threads as loop.close() doesn't join them.
Fixes #503