Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made object streams co/contravariant #483

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Made object streams co/contravariant #483

merged 1 commit into from
Oct 21, 2022

Conversation

agronholm
Copy link
Owner

Fixes #466.

jonathanslenders
jonathanslenders reviewed Oct 21, 2022
View reviewed changes
tests/streams/test_memory.py
@@ -345,3 +346,18 @@ async def test_sync_close() -> None:

with pytest.raises(ClosedResourceError):
receive_stream.receive_nowait()


async def test_type_variance() -> None:
Copy link
Contributor

@jonathanslenders jonathanslenders Oct 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! <3

@agronholm agronholm merged commit 1dabfd8 into master Oct 21, 2022
@agronholm agronholm deleted the fix-466 branch October 21, 2022 08:41
agronholm added a commit that referenced this pull request May 8, 2023
@agronholm
Made object streams co/contravariant (#483)
90e8de6 
Fixes #466.

(cherry picked from commit 1dabfd8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanslenders jonathanslenders jonathanslenders left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T_Item for MemoryObject{Send,Receive}Stream should be {contra,co}variant.
2 participants
@agronholm @jonathanslenders