Allow passing only item_type to create_memory_object_stream()
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind adding this to the changelog too? There's a section about type hint improvements. |
|
If you rebase this on top of |
gschaffner
changed the title
create_memory_object_stream(item_type=int) type checking failureitem_type to create_memory_object_stream()
agronholm
approved these changes
Oct 14, 2022
|
Thanks! |
agronholm
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 3b03178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Calls with a signature like
create_memory_object_stream(item_type=int)are supported by the implementation but not by the overloads.