Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch RuntimeError in finalization of start_blocking_portal() #472

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Catch RuntimeError in finalization of start_blocking_portal() #472

merged 4 commits into from
Oct 18, 2022

Conversation

agronholm
Copy link
Owner

Fixes #471.

smurfix
smurfix approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@smurfix smurfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane at first glance. Unfortunately I have no time to do an in-depth analysis

@agronholm agronholm merged commit 446e246 into master Oct 18, 2022
@agronholm agronholm deleted the fix-blockingportal-runtimeerror branch October 18, 2022 07:29
@agronholm
Copy link
Owner Author

Thanks for looking.

@jonathanslenders
Copy link
Contributor

Thank you!

agronholm added a commit that referenced this pull request May 7, 2023
@agronholm
Catch RuntimeError in finalization of start_blocking_portal() (#472)
75a08fc 
Fixes #471.

(cherry picked from commit 446e246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smurfix smurfix smurfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseException not returned though blockingportal.start_task_soon(...).result()
3 participants
@agronholm @jonathanslenders @smurfix