Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in readme #444

Merged
merged 3 commits into from
Jun 19, 2022
Merged

Fix typo in readme #444

merged 3 commits into from
Jun 19, 2022

Conversation

danielhasan1
Copy link
Contributor

fix typo

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes grammatical errors, not typos. But the fixes look alright.

@danielhasan1
Copy link
Contributor Author

It fixes grammatical errors, not typos. But the fixes look alright.

Thanks for the approval yeah I was checking it out and saw some sentences could be improved.

README.rst Outdated
with the native SC of trio itself.

Applications and libraries written against AnyIO's API will run unmodified on either asyncio_ or
trio_. AnyIO can also be adopted into a library or application incrementally – bit by bit, no full
refactoring necessary. It will blend in with native libraries of your chosen backend.
refactoring is necessary. It will blend in with the native libraries of your chosen backend.
Copy link
Collaborator

@graingert graingert Jun 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no full refactoring necessary is correct grammatically it's just more informal, changing to no refactoring is necessary changes the tone of the statement to be more formal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh okay. thanks for clearing that out.

README.rst Outdated Show resolved Hide resolved
@agronholm agronholm merged commit 8b05979 into agronholm:master Jun 19, 2022
agronholm pushed a commit that referenced this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants