tests: Remove use of AtEase

Something somewhere is leaving error_reporting in a dirty state
causing AbuseFilter's ConsequencesExecutorTest case to fail for
the core change Ic9fee6cdd88001025.

Wikibase is one of the CI dependencies of AbuseFilter.

Per T253461, we're meant to eventually remove these anyway, so might
as well get it over with avoid its state problems, which are especially
fragile during tests where exceptions are not uncommon, thus not
reaching the restore call.

Change-Id: I2a665f09a357f2f2cc258d8c4011d49a7ab9c13b

.phpcs.xml

@@ -45,6 +45,9 @@
 		<!-- Exclude test methods like "testGivenInvalidInput_methodThrowsException". -->
 		<exclude-pattern>tests*Test*\.php</exclude-pattern>
 	</rule>
+	<rule ref="Generic.PHP.NoSilencedErrors.Discouraged">
+		<exclude-pattern>tests/phpunit/*</exclude-pattern>
+	</rule>
 
 	<!-- NOTE: We can not use the Squiz.Arrays.ArrayBracketSpacing sniff because it conflicts with
 		the MediaWiki style that encourages to use spaces inside brackets, see

client/tests/phpunit/unit/includes/OtherProjectsSitesGeneratorTest.php

@@ -7,7 +7,6 @@
 use Site;
 use SiteLookup;
 use Wikibase\Client\OtherProjectsSitesGenerator;
-use Wikimedia\AtEase\AtEase;
 
 /**
  * @covers \Wikibase\Client\OtherProjectsSitesGenerator
@@ -88,12 +87,10 @@ public function testOtherProjectSiteIds_unknownSite() {
 
 		// getOtherProjectsSiteIds does wfWarn in case it's being called with a siteid
 		// it doesn't know about. That's fine, we can just ignore that.
-		AtEase::suppressWarnings();
-		$result = $otherProjectsSitesProvider->getOtherProjectsSiteIds( [
+		$result = @$otherProjectsSitesProvider->getOtherProjectsSiteIds( [
 			'wikipedia',
 			'wikisource',
 		] );
-		AtEase::restoreWarnings();
 
 		$this->assertSame( [], $result );
 	}

client/tests/phpunit/unit/includes/RecentChanges/RecentChangeFactoryTest.php

@@ -20,7 +20,6 @@
 use Wikibase\Lib\Changes\EntityDiffChangedAspectsFactory;
 use Wikibase\Lib\Changes\ItemChange;
 use Wikibase\Lib\Tests\Changes\MockRepoClientCentralIdLookup;
-use Wikimedia\AtEase\AtEase;
 use Wikimedia\TestingAccessWrapper;
 
 /**
@@ -463,9 +462,7 @@ public function testNewRecentChange_no_summary() {
 
 		$factory = $this->newRecentChangeFactory();
 
-		AtEase::suppressWarnings();
-		$rc = $factory->newRecentChange( $change, $target );
-		AtEase::restoreWarnings();
+		$rc = @$factory->newRecentChange( $change, $target );
 
 		$expectedComment = '(wikibase-comment-update)';
 		$this->assertEquals( $expectedComment, $rc->getAttribute( 'rc_comment' ) );

repo/tests/phpunit/includes/PidLockTest.php

@@ -3,7 +3,6 @@
 namespace Wikibase\Repo\Tests;
 
 use Wikibase\Repo\PidLock;
-use Wikimedia\AtEase\AtEase;
 
 /**
  * @covers \Wikibase\Repo\PidLock
@@ -25,10 +24,8 @@ public function testPidLock() {
 		$this->assertTrue( $pidLock->removeLock() );
 
 		// Make sure that the given file has actually been removed.
-		// unlink gives a warning if you use it a file that doesn't exist, suppress that
-		AtEase::suppressWarnings();
-		$this->assertFalse( $pidLock->removeLock() );
-		AtEase::restoreWarnings();
+		// ignore warning from unlink, e.g. if you use it a file that doesn't exist.
+		$this->assertFalse( @$pidLock->removeLock() );
 	}
 
 }

repo/tests/phpunit/includes/RepoHooksTest.php

@@ -29,7 +29,6 @@
 use Wikibase\Repo\RepoHooks;
 use Wikibase\Repo\Store\RateLimitingIdGenerator;
 use Wikibase\Repo\WikibaseRepo;
-use Wikimedia\AtEase\AtEase;
 
 /**
  * @covers \Wikibase\Repo\RepoHooks
@@ -294,9 +293,7 @@ public function importProvider() {
 	 */
 	public function testImportHandleRevisionXMLTag_hook( $xml, $allowImport, $expectedException = null ) {
 		// WikiImporter tried to register this protocol every time, so unregister first to avoid errors.
-		AtEase::suppressWarnings();
-		stream_wrapper_unregister( 'uploadsource' );
-		AtEase::restoreWarnings();
+		@stream_wrapper_unregister( 'uploadsource' );
 
 		$this->getSettings()->setSetting( 'allowEntityImport', $allowImport );
 

view/tests/phpunit/Template/TemplateRegistryTest.php

@@ -3,7 +3,6 @@
 namespace Wikibase\View\Tests\Template;
 
 use Wikibase\View\Template\TemplateRegistry;
-use Wikimedia\AtEase\AtEase;
 
 /**
  * @covers \Wikibase\View\Template\TemplateRegistry
@@ -45,12 +44,7 @@ public function testGetKnownTemplate() {
 
 	public function testGetUnknownTemplate() {
 		$registry = new TemplateRegistry( [] );
-
-		AtEase::suppressWarnings();
-		$html = $registry->getTemplate( 'unknown' );
-		AtEase::restoreWarnings();
-
-		$this->assertNull( $html );
+		$this->assertNull( @$registry->getTemplate( 'unknown' ) );
 	}
 
 }