Upgrade wikibase codesniffer to 1.0.0

This is the result of running composer fix; everything else is disabled
for now.

Bug: T235326
Depends-On: Ie7275ea3ea73416068a19e3c58fb7cd352c51409
Change-Id: I511b1604c31f67e3c32c43dbaa270683c7267114

.phpcs.xml

@@ -1,6 +1,22 @@
 <?xml version="1.0"?>
 <ruleset>
-	<rule ref="./vendor/wikibase/wikibase-codesniffer/Wikibase" />
+	<rule ref="./vendor/wikibase/wikibase-codesniffer/Wikibase">
+		<exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
+		<exclude name="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgContLang" />
+		<exclude name="MediaWiki.Usage.NullableType.PHP71NullableStyle" />
+		<exclude name="PSR2.Classes.ClassDeclaration.InterfaceWrongIndent" />
+		<exclude name="Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed" />
+		<exclude name="MediaWiki.Usage.MagicConstantClosure.FoundConstantMethod" />
+		<exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedException" />
+		<exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedExceptionMessage" />
+		<exclude name="MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation" />
+		<exclude name="Squiz.PHP.NonExecutableCode.ReturnNotRequired" />
+		<exclude name="Squiz.PHP.NonExecutableCode.Unreachable" />
+		<exclude name="PSR2.Classes.ClassDeclaration.InterfaceSameLine" />
+		<exclude name="PSR2.Classes.ClassDeclaration.FirstInterfaceSameLine" />
+		<exclude name="Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint" />
+		<exclude name="PSR12.Files.ImportStatement.LeadingSlash" />
+	</rule>
 
 	<rule ref="Generic.Files.LineLength">
 		<properties>
@@ -22,7 +38,7 @@
 		<!-- FIXME: These files should be renamed to match their class name. -->
 		<exclude-pattern>build/generateAutoload\.php</exclude-pattern>
 	</rule>
-	<rule ref="MediaWiki.VariableAnalysis.ForbiddenGlobalVariables.ForbiddenGlobal$wgTitle">
+	<rule ref="MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgTitle">
 		<exclude-pattern>RepoHooks\.php</exclude-pattern>
 	</rule>
 	<rule ref="PSR1.Classes.ClassDeclaration.MultipleClasses">

client/includes/ChangeNotificationJob.php

@@ -37,7 +37,7 @@ class ChangeNotificationJob extends Job {
 	/**
 	 * Constructs a ChangeNotificationJob representing the changes given by $changeIds.
 	 *
-	 * @note: the constructor's signature is dictated by Job::factory, so we'll have to
+	 * @note the constructor's signature is dictated by Job::factory, so we'll have to
 	 *           live with it even though it's rather ugly for our use case.
 	 *
 	 * @see      Job::factory.

client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php

@@ -32,7 +32,7 @@ class WikibaseLanguageDependentLuaBindings {
 	 * @param EntityIdParser $entityIdParser
 	 * @param FallbackLabelDescriptionLookup $labelDescriptionLookup
 	 *
-	 * @note: label usage is not tracked in $usageAccumulator. This should be done inside
+	 * @note label usage is not tracked in $usageAccumulator. This should be done inside
 	 *        the $labelDescriptionLookup or an underlying TermsLookup.
 	 */
 	public function __construct(

client/includes/Store/TitleFactory.php

@@ -58,7 +58,7 @@ public function newFromText( $text, $defaultNamespace = \NS_MAIN ) {
 
 	/**
 	 * @see Title::makeTitle
-	 * @note: Use this only with values that can be assumed to be safe and already validated!
+	 * @note Use this only with values that can be assumed to be safe and already validated!
 	 * For unsafe values, use makeTitleSafe() instead.
 	 *
 	 * @param int $ns
@@ -86,7 +86,7 @@ public function makeTitle( $ns, $text, $fragment = '', $interwiki = '' ) {
 
 	/**
 	 * @see Title::makeTitleSafe
-	 * @note: If all parameters have been validated and can be assumed to be safe,
+	 * @note If all parameters have been validated and can be assumed to be safe,
 	 * makeTitle() can be used, which should be a little faster.
 	 *
 	 * @param int $ns

client/maintenance/populateInterwiki.php

@@ -129,7 +129,7 @@ protected function doPopulate( array $data, $force ) {
 				__METHOD__
 			);
 
-			if ( ! $row ) {
+			if ( !$row ) {
 				$dbw->insert(
 					'interwiki',
 					[

client/tests/phpunit/includes/Api/ApiClientInfoTest.php

@@ -31,7 +31,7 @@ class ApiClientInfoTest extends \MediaWikiTestCase {
 	 */
 	protected $apiContext;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$this->apiContext = new ApiTestContext();

client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php

@@ -26,7 +26,7 @@
  */
 class ApiListEntityUsageTest extends MediaWikiLangTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		$this->tablesUsed[] = 'wbc_entity_usage';
 		parent::setUp();
 

client/tests/phpunit/includes/Api/ApiPropsEntityUsageTest.php

@@ -27,7 +27,7 @@
  */
 class ApiPropsEntityUsageTest extends MediaWikiLangTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		$this->tablesUsed[] = 'wbc_entity_usage';
 		parent::setUp();
 

client/tests/phpunit/includes/Api/DescriptionTest.php

@@ -33,7 +33,7 @@ class DescriptionTest extends TestCase {
 	 */
 	private $continueEnumParameter;
 
-	public function setUp() {
+	public function setUp() : void {
 		parent::setUp();
 		$this->resultData = [];
 		$this->continueEnumParameter = null;

client/tests/phpunit/includes/DataAccess/DataAccessSnakFormatterOutputFormatTest.php

@@ -42,7 +42,7 @@ class DataAccessSnakFormatterOutputFormatTest extends \PHPUnit\Framework\TestCas
 	/**
 	 * Makes sure WikibaseClient uses our ClientStore mock
 	 */
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$wikibaseClient = WikibaseClient::getDefaultInstance( 'reset' );
@@ -112,7 +112,7 @@ private function setUpDummyData( MockClientStore $store, $siteId ) {
 		$mockRepository->putEntity( $item );
 	}
 
-	public function tearDown() {
+	public function tearDown() : void {
 		parent::tearDown();
 
 		WikibaseClient::getDefaultInstance( 'reset' );

client/tests/phpunit/includes/DataAccess/ParserFunctions/PropertyParserFunctionIntegrationTest.php

@@ -35,7 +35,7 @@ class PropertyParserFunctionIntegrationTest extends MediaWikiTestCase {
 	 */
 	private $oldAllowDataAccessInUserLanguage;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$wikibaseClient = WikibaseClient::getDefaultInstance( 'reset' );
@@ -76,7 +76,7 @@ private function maskPropertyLabelResolver( WikibaseClient $wikibaseClient ) {
 		$wikibaseClient->propertyLabelResolver = $propertyLabelResolver;
 	}
 
-	protected function tearDown() {
+	protected function tearDown() : void {
 		parent::tearDown();
 
 		$this->setAllowDataAccessInUserLanguage( $this->oldAllowDataAccessInUserLanguage );

client/tests/phpunit/includes/DataAccess/ParserFunctions/StatementsParserFunctionIntegrationTest.php

@@ -54,7 +54,7 @@ class StatementsParserFunctionIntegrationTest extends MediaWikiTestCase {
 	 */
 	private $store;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$wikibaseClient = WikibaseClient::getDefaultInstance( 'reset' );
@@ -100,7 +100,7 @@ private function maskPropertyLabelResolver( WikibaseClient $wikibaseClient ) {
 		$wikibaseClient->propertyLabelResolver = $propertyLabelResolver;
 	}
 
-	protected function tearDown() {
+	protected function tearDown() : void {
 		parent::tearDown();
 
 		$this->setAllowDataAccessInUserLanguage( $this->oldAllowDataAccessInUserLanguage );

client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php

@@ -38,7 +38,7 @@ protected function getTestModules() {
 		];
 	}
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$settings = WikibaseClient::getDefaultInstance()->getSettings();

client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTest.php

@@ -53,7 +53,7 @@ protected static function getEntityAccessLimit() {
 		return 2;
 	}
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$settings = WikibaseClient::getDefaultInstance()->getSettings();

client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php

@@ -21,7 +21,7 @@
 	 */
 	abstract class Scribunto_LuaWikibaseLibraryTestCase extends \PHPUnit\Framework\TestCase {
 
-		protected function setUp() {
+		protected function setUp() : void {
 			$this->markTestSkipped( 'Scribunto is not available' );
 		}
 
@@ -133,7 +133,7 @@ public static function suite( $className ) {
 		return $res;
 	}
 
-	protected function setUp() {
+	protected function setUp() : void {
 		if ( !WikibaseSettings::isRepoEnabled() ) {
 			$this->markTestSkipped( "Skipping because a local wb_terms table"
 				. " is not available on a WikibaseClient only instance." );

client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseStatsTest.php

@@ -32,7 +32,7 @@ protected function getTestModules() {
 		];
 	}
 
-	public function setUp() {
+	public function setUp() : void {
 		parent::setUp();
 
 		$mwServices = MediaWikiServices::getInstance();

client/tests/phpunit/includes/Hooks/ChangesListSpecialPageHookHandlersTest.php

@@ -36,7 +36,7 @@ class ChangesListSpecialPageHookHandlersTest extends \PHPUnit\Framework\TestCase
 	 */
 	protected $oldExtensionRegistryLoaded;
 
-	public function setUp() {
+	public function setUp() : void {
 		parent::setUp();
 
 		$this->extensionRegistry = TestingAccessWrapper::newFromObject(
@@ -51,7 +51,7 @@ public function setUp() {
 		$this->extensionRegistry->loaded = [ 'Wikibase' ];
 	}
 
-	public function tearDown() {
+	public function tearDown() : void {
 		parent::tearDown();
 
 		$this->extensionRegistry->loaded = $this->oldExtensionRegistryLoaded;

client/tests/phpunit/includes/Hooks/DeletePageNoticeCreatorTest.php

@@ -22,7 +22,7 @@
  */
 class DeletePageNoticeCreatorTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$this->setUserLang( 'de' );

client/tests/phpunit/includes/Hooks/EchoNotificationsHandlersTest.php

@@ -35,7 +35,7 @@ class EchoNotificationsHandlersTest extends MediaWikiTestCase {
 	 */
 	private $namespaceChecker;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 		if ( !ExtensionRegistry::getInstance()->isLoaded( 'Echo' ) ) {
 			$this->markTestSkipped( "Echo not loaded" );

client/tests/phpunit/includes/Hooks/MovePageNoticeTest.php

@@ -25,7 +25,7 @@
  */
 class MovePageNoticeTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$this->setUserLang( 'de' );

client/tests/phpunit/includes/Hooks/NoLangLinkHandlerTest.php

@@ -30,7 +30,7 @@ class NoLangLinkHandlerTest extends \PHPUnit\Framework\TestCase {
 	 */
 	private $namespacesToInclude;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		$settings = WikibaseClient::getDefaultInstance()->getSettings();
 
 		$this->excludeNamespaces = $settings->getSetting( 'excludeNamespaces' );
@@ -40,7 +40,7 @@ protected function setUp() {
 		$settings->setSetting( 'namespaces', [] );
 	}
 
-	protected function tearDown() {
+	protected function tearDown() : void {
 		$settings = WikibaseClient::getDefaultInstance()->getSettings();
 
 		$settings->setSetting( 'excludeNamespaces', $this->excludeNamespaces );

client/tests/phpunit/includes/Hooks/ParserClearStateHookHandlerTest.php

@@ -24,7 +24,7 @@
  */
 class ParserClearStateHookHandlerTest extends MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$wikibaseClient = WikibaseClient::getDefaultInstance( 'reset' );
@@ -42,7 +42,7 @@ protected function setUp() {
 		);
 	}
 
-	protected function tearDown() {
+	protected function tearDown() : void {
 		parent::tearDown();
 
 		WikibaseClient::getDefaultInstance( 'reset' );

client/tests/phpunit/includes/Hooks/ShortDescHandlerTest.php

@@ -23,7 +23,7 @@ class ShortDescHandlerTest extends TestCase {
 	 */
 	private $handler;
 
-	public function setUp() {
+	public function setUp() : void {
 		parent::setUp();
 		$this->handler = new ShortDescHandler();
 	}

client/tests/phpunit/includes/Hooks/SkinTemplateOutputPageBeforeExecHandlerTest.php

@@ -122,7 +122,7 @@ private function getTemplate( $languageUrls, &$actualLanguageUrls, &$actualWbedi
 				} elseif ( $name === 'wbeditlanglinks' ) {
 					$actualWbeditlanglinks = $val;
 				} else {
-					TestCase::fail( 'Unexpected option ' .  $name . ' set.' );
+					TestCase::fail( 'Unexpected option ' . $name . ' set.' );
 				}
 			} ) );
 

client/tests/phpunit/includes/LangLinkHandlerTest.php

@@ -62,7 +62,7 @@ private function getItems() {
 		return $items;
 	}
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$this->langLinkHandler = $this->getLangLinkHandler();

client/tests/phpunit/includes/Notifications/PageConnectionPresentationModelTest.php

@@ -25,7 +25,7 @@
  */
 class PageConnectionPresentationModelTest extends MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 		if ( !ExtensionRegistry::getInstance()->isLoaded( 'Echo' ) ) {
 			$this->markTestSkipped( "Echo not loaded" );

client/tests/phpunit/includes/RecentChanges/ChangeLineFormatterTest.php

@@ -37,7 +37,7 @@ class ChangeLineFormatterTest extends MediaWikiLangTestCase {
 
 	protected $repoLinker;
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		// these are required because Linker is used in ChangeLineFormatter

client/tests/phpunit/includes/RecentChanges/RecentChangesDuplicateDetectorTest.php

@@ -20,7 +20,7 @@
  */
 class RecentChangesDuplicateDetectorTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$this->tablesUsed[] = 'recentchanges';

client/tests/phpunit/includes/Store/Sql/BulkSubscriptionUpdaterTest.php

@@ -26,7 +26,7 @@
  */
 class BulkSubscriptionUpdaterTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		if ( !WikibaseSettings::isRepoEnabled() ) {
 			$this->markTestSkipped( "Skipping because WikibaseClient doesn't have a local wb_changes_subscription table." );
 		}

client/tests/phpunit/includes/Store/Sql/PagePropsEntityIdLookupTest.php

@@ -23,7 +23,7 @@
  */
 class PagePropsEntityIdLookupTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		$this->tablesUsed[] = 'page_props';
 		parent::setUp();
 	}

client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php

@@ -24,7 +24,7 @@
  */
 class EntityUsageTableBuilderTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		$this->tablesUsed[] = EntityUsageTable::DEFAULT_TABLE_NAME;
 		$this->tablesUsed[] = 'page_props';
 

client/tests/phpunit/includes/Usage/Sql/EntityUsageTableTest.php

@@ -25,7 +25,7 @@
  */
 class EntityUsageTableTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		parent::setUp();
 
 		$this->tablesUsed[] = EntityUsageTable::DEFAULT_TABLE_NAME;

client/tests/phpunit/includes/Usage/Sql/SqlSubscriptionManagerTest.php

@@ -22,7 +22,7 @@
  */
 class SqlSubscriptionManagerTest extends \MediaWikiTestCase {
 
-	protected function setUp() {
+	protected function setUp() : void {
 		if ( !WikibaseSettings::isRepoEnabled() ) {
 			$this->markTestSkipped( 'Skipping test for SqlSubscriptionManager, '
 				. 'because the repo-side table wb_changes_subscription is not available.' );