Fix: On multiple reports, the data and dataset are overriden when hav… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same definition If you want to print an array of reports with the same definition (same report name), line 206 was referencing instead of copying the definition. So, you are modifying the data and dataset properties (line 222 and 223) for all and getting the last values of the last element of the loop (line 209). It is necessary to copy the definition and not get a reference.
|
Hello @agmoyano do you have any conflict regarding my proposal? |
|
Hello @agmoyano please check my pull request. Thank you |
agmoyano
added a commit
that referenced
this pull request
Dec 21, 2015
Fix: On multiple reports, the data and dataset are overriden when hav…
|
Thanks for PR, sorry I didn't see it sooner. Regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e same definition
If you want to print an array of reports with the same definition (same report name), line 206 was referencing instead of copying the definition. So, you are modifying the data and dataset properties (line 222 and 223) for all and getting the last values of the last element of the loop (line 209).
It is necessary to copy the definition and not get a reference.