Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for coverage #193

Merged
merged 14 commits into from
Feb 7, 2022
Merged

Add tests for coverage #193

merged 14 commits into from
Feb 7, 2022

Conversation

patrick-reinhard
Copy link
Collaborator

@patrick-reinhard patrick-reinhard commented Jan 27, 2022

  • Adding tests, increasing coverage of welly dir to 73%
  • PEP8 formatting
  • Small fixes for Curve methods, passing through keyword arguments.
  • Two fixes to make welly compatible with python versions 3.8, 3.9, 3.10
    • pd.set_option('display.precision') and pd.set_option('precision')
    • ax.plot() not working when passing a df and an np.array, transform df to np.array before passing to plot function

image

@kwinkunks kwinkunks merged commit 73d9258 into develop Feb 7, 2022
@kwinkunks
Copy link
Member

Nice - thank you.

NB You have tests themselves and some PyCharm stuff in there. I just added a .coveragerc file which solves this issue for me; probably depends how you're running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants