Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrick/fixes for pandas issues #185

Merged
merged 5 commits into from
Jan 10, 2022
Merged

Conversation

patrick-reinhard
Copy link
Collaborator

@patrick-reinhard patrick-reinhard commented Jan 10, 2022

Some fixes for the outstanding issues for the 0.5.0 release.

Fixes for open issues:

Other related and unrelated fixes:

  • Fix for survey_basis() with unequal basis and descending basis. We're currently allowing for descending curve index/basis. This was not accounted for in this method.
  • Small fixes for curve type casting and properties.
  • Small formatting changes.

@kwinkunks
Copy link
Member

Nice, thank you! Reviewing...

Indeed, I think data_as_matrix needs review. Maybe it's not needed, although the resampling option is potentially quite useful. Besides, it would need to be derprecated.

@kwinkunks kwinkunks merged commit 8efa436 into develop Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants