Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Curve object with pd.DataFrame #170

Conversation

patrick-reinhard
Copy link
Collaborator

@patrick-reinhard patrick-reinhard commented Oct 21, 2021

Hi @kwinkunks, please have a look at this draft PR covering:

  • Moving out quality and plotting functionality from class methods to dedicated quality.py and plot.py modules.
  • Moving out reader/writer logic from class methods to dedicated las.py module.
  • Replacing subclassed np.array Curve class with a custom class object that is composed (has a) pd.DataFrame and meta data attributes. If you want to operate on the data you need to operate on curve.df instead on the curve directly.
  • Add constructor methods Well.from_datasets()., keeping Well.from_lasio() and Well.from_las() intact.
  • Moved test example files to assets subdirectory. Added conftest.py that constructs a test well that can be called by all tests in the tests directory, speeding up test ensemble execution.

To do:

  • Adapt interfaces for new Curve object, repo internally and with striplog.
  • Replace replication of pandas functionality, mostly around the concept of basis
  • Add tests

There's still a lot to do but it would be helpful if you can already have a first glance at the new Curve and datasets structure.

Kent Inverarity and others added 30 commits April 15, 2021 09:17
…nstall-requires

Wellpathpy not found with `pip install -e .`
wenting-x and others added 23 commits October 21, 2021 22:00
plot_curve function
…unctions-curve-with-dataframe

Adapting methods and functions for new curve object
@kwinkunks kwinkunks changed the base branch from master to pandas November 10, 2021 15:07
@kwinkunks kwinkunks marked this pull request as ready for review November 10, 2021 15:07
@kwinkunks kwinkunks merged commit 5b62825 into agilescientific:pandas Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants