Deviation #161
Merged
Deviation #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are planning to move welly over to wellpathpy for all deviation handling tasks and so this becomes an additional lightweight dependancy.
In the process of moving welly to use wellpathpy to handle all deviation and position data, the API has not been changed in location.py, rather the compute_position_log function now uses wellpathpy to return the same objects as it did previously. There are no breaking changes but there are now additional methods available to welly to compute a position log. The same adjustments to TD, surface and azimuth_datum that were made previously have simply been included in the new function and remain in welly, rather than being added to wellpathpy.
After switching over to the new function using wellpathpy the old one is now redundant.
Wellpathpy is now used to handle deviation and provide position logs to welly, no changes were made to the API as the compute_position_log function was refactored transparently to location.py
Welly wants to report dls in radians, unlike wellpathpy that reports it in degrees. This is now fixed to revert back to welly'y preferred behaviour.
This commit converted dls to radians but the error was not caught by existing tests. A new assertion is added to catch that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, Welly learns to use wellpathpy to handle deviation data and generate position logs. The API has not changed in
location.pyand the underlying functioncompute_position_lognow provides exactly the same interface and same options as previously, but in addition position logs can be calculated with the high and low tangential methods as well as with the radius of curvature method.Wellpathpy becomes another dependency.